Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle duality Json View optimization in property comparison and sort #3222

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

@radovanradic radovanradic added the type: improvement A minor improvement to an existing feature label Nov 12, 2024
sb.append(".number()");
sb.append(".numberOnly()");
} else if (dataType == DataType.STRING) {
sb.append(".stringOnly()");
} else if (dataType == DataType.TIMESTAMP) {
sb.append(".timestamp()");
} else if (dataType == DataType.DATE) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems these can be used in the SELECT statement as well and there are others like dateOnly()

Should we be optimising them all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using them when there are projections (like findNameById and similar) and now also for comparison and ordering.
I tried dateOnly() and got the exception

ORA-40597: JSON path expression syntax error ('$.birthDate.dateOnly()')
JZN-00241: Message 241 not found; No message file for product=XDK, facility=JZN Message 200 not found; No message file for product=XDK, facility=JZN

So I wouldn't like to break something and will use .date() like it was before.

@radovanradic radovanradic merged commit b671498 into 4.10.x Nov 13, 2024
53 checks passed
@radovanradic radovanradic deleted the jsonview-improvements branch November 13, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants