Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements and fix Azure #157

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Documentation improvements and fix Azure #157

merged 6 commits into from
Nov 29, 2023

Conversation

timyates
Copy link
Contributor

Worked through the documentation for the Telegram bots

Fixed the configuration properties javadocs for ChatbotsConfiguration

Re-ordered the telegram docs to a more sensible order.

Added tested examples for static resource rendering and ordering

@timyates timyates added this to the 1.0.0 milestone Nov 28, 2023
@timyates timyates requested a review from sdelamo November 28, 2023 14:19
@timyates timyates self-assigned this Nov 28, 2023
@timyates
Copy link
Contributor Author

@sdelamo The Basecamp docs may need some love, but I cannot crate a basecamp bot (that I can see), as you need to have admin rights 🤔

@timyates
Copy link
Contributor Author

timyates commented Nov 28, 2023

Tried to test the Azure function, but I'm currently seeing:

ClassCastException: Cannot convert 
    com.microsoft.azure.functions.worker.binding.RpcHttpRequestDataSource@5a2f6ef1
to type
    com.microsoft.azure.functions.HttpRequestMessage<io.micronaut.chatbots.telegram.api.Update>

🤔

@timyates
Copy link
Contributor Author

Actually... I think the issue is

NumberFormatException: Expected an int but was 6627731281 at line 2 column 50 path $.message.from.id

And ID here says we should use a 64bit number format

@timyates
Copy link
Contributor Author

@timyates
Copy link
Contributor Author

Azure header names come in lower-case.... such fun...

@timyates timyates changed the title Documentation improvements Documentation improvements and fix Azure Nov 28, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

77.3% 77.3% Coverage
2.7% 2.7% Duplication

@timyates
Copy link
Contributor Author

@sdelamo Merging this as it's blocking my starter tests, please let me know if you see something wrong

@timyates timyates merged commit 6ec9e65 into master Nov 29, 2023
12 checks passed
@timyates timyates deleted the manual branch November 29, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant