Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AwsCredentialsProvider and AwsRegionProvider interfaces for bean … #1034

Open
wants to merge 1 commit into
base: 5.0.x
Choose a base branch
from

Conversation

shduke
Copy link

@shduke shduke commented Apr 17, 2021

…declaration instead of their Chain classes

Declaring these beans using their interfaces will make them easier to override.

AwsCredentialsProviderChain is a final class, which prevent AOP proxying (e.g. it prevent using the @MockBean annotation directly).

Using the @Replaces() annotation works; however, these beans should be thought of (and are logically being used) as a black box implementation of their Provider interface.

AwsRegionProviderChain is not a final class; however, if AwsCredentialsProviderChain is changed then AwsRegionProviderChain should be changed as well for consistency.

@graemerocher graemerocher requested a review from sdelamo April 27, 2021 13:20
@sdelamo sdelamo self-assigned this May 4, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants