Use AwsCredentialsProvider and AwsRegionProvider interfaces for bean … #1034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…declaration instead of their Chain classes
Declaring these beans using their interfaces will make them easier to override.
AwsCredentialsProviderChain is a final class, which prevent AOP proxying (e.g. it prevent using the
@MockBean
annotation directly).Using the @Replaces() annotation works; however, these beans should be thought of (and are logically being used) as a black box implementation of their Provider interface.
AwsRegionProviderChain is not a final class; however, if AwsCredentialsProviderChain is changed then AwsRegionProviderChain should be changed as well for consistency.