Fix error on MySQL backend when bsToken null #63
Conversation
This commit fixes an error when the bootstrap token for a device is NULL. Apple specifies[0] the behaviour of `GetBootstrapToken` to return an empty body when there is no bootstrap token for the device. This behaviour has been conformed to. [0]: https://developer.apple.com/documentation/devicemanagement/get_bootstrap_token
8f60298 to
0287471
Compare
There was a problem hiding this comment.
So firstly: the actual changes to the storage backend and the service code are 👍. However the tests I think need some adjustment. Notably around including a new dependency (uuid) and how a new device is created.
Because you're creating a new "enrollment" from actual messages like Authenticate you don't need to generate a UUID — it's already in the Authenticate message and you can Resolve() it into a form that you can use in an mdm.Request (like the nanomdm service does for a real incoming enrollment). If you look at the parsed Authenticate.2.plist message that's the same UUID in the code — I'm not sure why I didn't do this myself in the existing test.
I'm also on the fence about (but leaning against) moving the Enrollment test harness stuff to the shared test package. Enrollment and test data I think should be closer to the actual test. Not to mention — are the relative testdata file paths from where the test is executed from or from where the package resides? I suspect the former. Since it's a shared test module the pathing will be indeterminate (though likely quite predicable given the flat-ish nature of the existing modules).
fab346a to
b07690d
Compare
This commit refactors the MySQL tests, and puts some common code into the storage test library. Instead of depending on the "github.com/google/uuid" library, we grab device UDIDs from our test data. The pgsql changes should also be refactored to use these changes, but I think that deserves another PR.
This commit fixes an error when the bootstrap token for a device is NULL. Apple specifies the behaviour of
GetBootstrapTokento return an empty body when there is no bootstrap token for the device. This behaviour has been conformed to.