Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported fields to Authenticate struct type #62

Conversation

gillespi314
Copy link

Adds DeviceName, Model, and ModelName to Authenticate struct, which are required fields for an AuthenticateRequest according to Apple's documentation

@gillespi314 gillespi314 deleted the sg-add-supported-fields-authenticate branch December 20, 2022 16:41
@gillespi314 gillespi314 restored the sg-add-supported-fields-authenticate branch December 20, 2022 16:41
@gillespi314
Copy link
Author

This PR was intended for a fork and was mistakenly opened here.

@jessepeterson
Copy link
Member

For what it's worth: the table-prefix thing is a feature I've thought about adding. Having a configurable/dynamic option for that might be useful. Downgrading the syntax to MySQL 5.x isn't something we'll likely support (though — I might be open to adding a mysql5 backend. Maybe. Maybe not.

As far as the actual fields — we don't need to support them because none of the storage backends use them and the Raw authenticate message is passed to any integrations (notably the web hook). As well, in mysql backend the Raw authentication message is stored on the device record. So anybody can use those fields if they wish without having to add them. Though I might be open to adding them if a storage backend (or integration) really needed them (like we do for e.g. serial number).

@jessepeterson
Copy link
Member

Added #64 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants