pgsql #51
pgsql #51
Conversation
Co-authored-by: Jesse Peterson <jessepeterson@users.noreply.github.com>
Co-authored-by: Jesse Peterson <jessepeterson@users.noreply.github.com>
Co-authored-by: Jesse Peterson <jessepeterson@users.noreply.github.com>
Co-authored-by: Jesse Peterson <jessepeterson@users.noreply.github.com>
# Conflicts: # cmd/cli/cli.go # docs/operations-guide.md
There was a problem hiding this comment.
This is great! Just a couple really minor things this time 'round. Also I was able to throw a PostgreSQL instance up and use the nano2nano tool to migrate my enrollments to it and it all seems to be working great on very initial poking at it!
storage/mysql/mysql.go
Outdated
| @@ -1,4 +1,4 @@ | |||
| // Pacakge mysql stores and retrieves MDM data from SQL | |||
| // Package mysql Package mysql stores and retrieves MDM data from MySQL | |||
There was a problem hiding this comment.
Duplicated 'package mysql'?
storage/pgsql/certauth.go
Outdated
| r.Context, ` | ||
| INSERT INTO cert_auth_associations (id, sha256) | ||
| VALUES ($1, $2) | ||
| ON CONFLICT ON CONSTRAINT cert_auth_associations_pkey DO NOTHING;`, |
There was a problem hiding this comment.
Nice! I see you added this from your comment from #50.
There was a problem hiding this comment.
On second thought there is one reason why you might not want to DO NOTHING. And that's to update the timestamp. Does the timestamp update on a do nothing?
There was a problem hiding this comment.
updated_at time doesn't update on "do nothing". The solution is
ON CONFLICT ON CONSTRAINT cert_auth_associations_pkey DO UPDATE SET updated_at=now();
Should I make changes?
| } | ||
|
|
||
| // previous: `SELECT id, topic, push_magic, token_hex FROM enrollments WHERE id IN (`+qs+`);`, | ||
| // refactor all strings concatenations with strings.Builder which is more efficient |
| @@ -0,0 +1,111 @@ | |||
| //go:build integration | |||
Co-authored-by: Jesse Peterson <jessepeterson@users.noreply.github.com>
There was a problem hiding this comment.
lgtm! note to others the previous review with comments was under #50.
Added PostgreSQL storage.
All conflicts solved. Integration tests pass ok.
Enrolled a real device, tested with cmdr.py commands - ok. Compared the results in multi-storage mode MySQL - PostgreSQL. Data in both DB tables are the same.