Accomodate large command results #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thanks! We'll also need to have a schema change file to do an ALTER TABLE. |
|
Also: we could go larger with LONGTEXT as well. |
I thought about it but proposed MEDIUMTEXT since LONGTEXT can be up to 4GB and |
I added schema.00005.sql with the ALTER statement, is that what you mean? |
jessepeterson
requested changes
Aug 7, 2021
Co-authored-by: Jesse Peterson <jessepeterson@users.noreply.github.com>
jessepeterson
approved these changes
Aug 10, 2021
w0de
added a commit
to w0de/nanomdm
that referenced
this pull request
Dec 14, 2021
* change command_result.result to `MEDIUMTEXT` * create storage/mysql/schema.00005.sql
w0de
added a commit
to w0de/nanomdm
that referenced
this pull request
Mar 17, 2022
* change command_result.result to `MEDIUMTEXT` * create storage/mysql/schema.00005.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When handling the command result response for InstalledApplicationList, nanomdm issues the following plea:
The InstalledApplicationList response for my current device - with only base Apple apps - is 117,465 characters of base64-endcoded text.
TEXTsupport 65,525 characters;MEDIUMTEXT, 16,777,215 (this corresponds to ~16.78 mb: "L + 3 bytes, where L < 2^24" - https://dev.mysql.com/doc/refman/8.0/en/storage-requirements.html#data-types-storage-reqs-strings)This works with current nanomdm release (in as much as I migrated with
schema.00005.sqland everything continued to work/InstalledApplicationListstarted working). MySQL docs do not have any warnings regarding migrating between text types that I found.