Merge pull request #18 from microlinkhq/next

ci: better testing setup

.github/workflows/main.yml

@@ -12,7 +12,7 @@ jobs:
   test:
     runs-on: ubuntu-latest
     container:
-      image: kikobeats/docker-browserless-vips:latest
+      image: kikobeats/docker-vips:latest
     steps:
       - name: Checkout
         uses: actions/checkout@v3

package.json

@@ -39,7 +39,7 @@
   "dependencies": {
     "debug-logfmt": "~1.0.4",
     "node-vibrant": "~3.2.1-alpha.1",
-    "sharp": "~0.30.0"
+    "sharp": "~0.30.3"
   },
   "devDependencies": {
     "@commitlint/cli": "latest",
@@ -50,7 +50,7 @@
     "conventional-github-releaser": "latest",
     "finepack": "latest",
     "git-authors-cli": "latest",
-    "hexsorter": "latest",
+    "hex-color-regex": "latest",
     "nano-staged": "latest",
     "npm-check-updates": "latest",
     "prettier-standard": "latest",
@@ -83,6 +83,9 @@
     "update:check": "ncu -- --error-level 2"
   },
   "license": "MIT",
+  "ava": {
+    "workerThreads": false
+  },
   "commitlint": {
     "extends": [
       "@commitlint/config-conventional"

test/index.js

@@ -1,39 +1,24 @@
 'use strict'
 
-const { isEmpty, clone, pull } = require('lodash')
-
-const hexSorter = require('hexsorter')
+const hexColorRegex = require('hex-color-regex')
 const path = require('path')
 const test = require('ava')
 const fs = require('fs')
 
 const splashy = require('..')
 const FIXTURES_PATH = path.resolve(__dirname, 'fixtures')
 
-const SKIP_EXTENSION_TESTS = ['.ico', '.bmp', '.mng']
-
 const images = fs.readdirSync(FIXTURES_PATH)
 
-const sortColors = colors => {
-  const input = clone(colors)
-  const output = []
-
-  while (!isEmpty(input)) {
-    const color = hexSorter.mostBrightColor(input)
-    pull(input, color)
-    output.push(color)
-  }
-
-  return output
-}
+const isHexcolor = hex => hexColorRegex({ strict: true }).test(hex)
 
 images.forEach(image => {
   const extension = path.extname(image)
-  ;(SKIP_EXTENSION_TESTS.includes(extension) ? test.skip : test)(extension, async t => {
+  test(extension, async t => {
     const filepath = path.resolve(path.resolve(FIXTURES_PATH, image))
     const buffer = fs.readFileSync(filepath)
     const colors = await splashy(buffer)
     t.true(colors.length > 0)
-    t.snapshot(sortColors(colors))
+    t.true(colors.every(isHexcolor))
   })
 })