-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pypi tarball no longer includes documentation.py #167
Comments
I decided to remove the tests from the tarball, I am not sure why test.py Is still there. I will have a look. |
In the wheel test.py is missing, as I expected, but it is present in the tarball, seems to be an idiosyncrasy of the new build process ( |
Ok, I would still like to run the unit tests during the building of the Arch Linux package to confirm that newer Python versions work correctly. So as alternative I am happy to switch to using git sources but I noticed there is no tag for 5.2.0 |
Ah, I forgot to push the tag! It is there now: https://github.com/micheles/decorator/releases/tag/5.2.0 |
That really sucks for us. Running the the test suite is crucial for packagers, as well as having a reliable source package available. And given that this is a pure Python package, all |
I am willing to make changes to help you packagers. My thinking was that everybody use wheels and people wanting the sources can get them from github: https://github.com/micheles/decorator/archive/refs/tags/5.2.0.tar.gz. |
For Arch I have switched to using Git as the source so if there are tags then it's all good. |
Git archives are unfortunately unreliable. Besides, we'd rather see source distributions in top shape, since once release signing lands in PyPI, they'll be even more important.
I'll take a shot at fixing the build. As for GitHub Actions, I think literally the equivalent of:
would work here. However, I'm not experienced with that. GitHub workflows have been compromised too many times for me to trust them for making releases. |
The released tarball contains
tests/test.py
but lackstests/documentation.py
which makes it impossible to run the unit tests during an Arch Linux package build.The text was updated successfully, but these errors were encountered: