build: added namespace for AGP version 7+. This should fix compatibil… #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity issues with gradle 8.
ifaiber
approved these changes
Aug 8, 2024
|
@michalchudziak would it be possible to get this reviewed and merged? This is currently a blocker for me on a project. |
michalchudziak
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ity issues with gradle 8.
Fixes issue #324
Overview
Some Android dependencies require Gradle 8. The only way this (rn geo location) can be used with Gradle 8 is by adding the namespace value.
Test Plan
Configure react native project with android gradle 8. Sync / build project.