fix: add manual discriminator mode #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+36
to
+41
|
|
||
| const manualDiscriminatorMatch = getOptionMatchingManualDiscriminator(discriminatorField, formData, options); | ||
| if (manualDiscriminatorMatch !== undefined) { | ||
| return manualDiscriminatorMatch; | ||
| } | ||
|
|
There was a problem hiding this comment.
This implementation already exists on lines 46-51. Are you trying to avoid the isValid check?
There was a problem hiding this comment.
Yes, this is exactly what I am doing - this makes all the difference between a fast vs. an unusably sluggish form in my use-case :)
There was a problem hiding this comment.
I'm wondering if the PR fix will help your use case once we release it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
[Please describe them here]
If this is related to existing tickets, include links to them as well. Use the syntax
fixes #[issue number](ex:fixes #123).If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit
Checklist
npm run test:updateto update snapshots, if needed.