Misc icon changes #432
Merged
Misc icon changes #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pinotree
commented
May 23, 2021
- drop the XPM icon, as it is redundant with the PNG icons in the XDG hicolor icon theme
- install also the 32px PNG application icon
The application icon is already provided as PNG in different sizes, and installed in the global XDG hicolor icon theme. Hence, there is no need to install the XPM version in the legacy pixmaps location.
Since it is already available, install it in addition to the other icons to avoid downscaling the bigger icons for small sizes.
|
The XPM is still needed for the X11 code path, but you're right I don't need to install it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.