Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not have numbered headers if table of contents is off #405

Closed
salomvary opened this issue Dec 11, 2020 · 5 comments
Closed

Can not have numbered headers if table of contents is off #405

salomvary opened this issue Dec 11, 2020 · 5 comments
Assignees
Labels
bug Something isn't working priority-medium
Milestone

Comments

@salomvary
Copy link

salomvary commented Dec 11, 2020

Hey @michaelrsweet, thanks for this excellent piece of software!

I noticed this small thing which might be a bug.

While this command results in numbered headings on the pages:

htmldoc --numbered  -f test.pdf test.html

Screenshot 2020-12-11 at 14 23 48

..this does not:

htmldoc --no-toc --numbered  -f test.pdf test.html

Screenshot 2020-12-11 at 14 23 36

Looks like TOC is mandatory if one wants numbered headers but maybe it should not be?

$ htmldoc --version
1.9.10

Using macOS 10.14.6 and Preview.app.

@michaelrsweet michaelrsweet self-assigned this Dec 11, 2020
@michaelrsweet michaelrsweet added the investigating Investigating the issue label Dec 11, 2020
@michaelrsweet
Copy link
Owner

@salomvary Um, are you sure you have those commands in the right order?

Anyways, will investigate as the two are not supposed to be connected...

@salomvary
Copy link
Author

@salomvary Um, are you sure you have those commands in the right order?

Uh oh, sorry I mixed them up while copypasting. Edited the description above.

@salomvary
Copy link
Author

This is the full sequence of commands that resulted in the second screenshot that has no numbered headings:

$ echo '<h1>one</h1><h2>two</h2>' > test.html
$ htmldoc --no-toc --numbered  -f test.pdf test.html
PAGES: 2
BYTES: 75476
$ open test.pdf 

@michaelrsweet michaelrsweet added bug Something isn't working priority-medium and removed investigating Investigating the issue labels Dec 24, 2020
@michaelrsweet michaelrsweet added this to the Stable milestone Dec 24, 2020
@michaelrsweet
Copy link
Owner

[master c3e825b] Fix --numbered with --no-toc (Issue #405)

@salomvary
Copy link
Author

Thanks a lot for the quick fix @michaelrsweet! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium
Projects
None yet
Development

No branches or pull requests

2 participants