Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression from issue #348 with nbsp and other entities #401

Closed
michaelrsweet opened this issue Oct 1, 2020 · 2 comments
Closed

Regression from issue #348 with nbsp and other entities #401

michaelrsweet opened this issue Oct 1, 2020 · 2 comments
Assignees
@michaelrsweet
Labels
bug Something isn't working priority-high
Milestone
Stable

Comments

@michaelrsweet
Copy link
Owner

The fixes for issue #348 have caused a regression with   and probably all entities that don't map to a US ASCII character.
@michaelrsweet michaelrsweet self-assigned this Oct 1, 2020
@michaelrsweet michaelrsweet added bug Something isn't working priority-high labels Oct 1, 2020
@michaelrsweet michaelrsweet added this to the Stable milestone Oct 1, 2020
@michaelrsweet michaelrsweet mentioned this issue Oct 1, 2020
Closed
@michaelrsweet
Copy link
Owner Author

@RekGRpth proposed a fix that is close to the right one - the iso8859() function isn't aware of the UTF-8 handling that was added, and so it doesn't do the necessary lookups.

michaelrsweet added a commit that referenced this issue Dec 5, 2020
@michaelrsweet
Fix HTML entitites in UTF-8 mode (Issue #401).
712f7ee 
- Refactor the UTF-8 to custom charset mapping code so there is a single
  function to handle the lookup/addition of chars, then call it from the 3
  places that need it...
@michaelrsweet
Copy link
Owner Author

[master 712f7ee] Fix HTML entitites in UTF-8 mode (Issue #401).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrsweet michaelrsweet

Labels
bug Something isn't working priority-high
Projects
None yet
Milestone
Stable
Development

No branches or pull requests
1 participant
@michaelrsweet