Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an upload definitions method to upload the definitions #220

Merged
merged 8 commits into from
Dec 12, 2021

Conversation

shubhang93
Copy link
Contributor

No description provided.

Copy link
Owner

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added test fails because no arguments provided on the input data, which makes in fail validation on the HTTP API endpoint side.

@shubhang93
Copy link
Contributor Author

All the tests are passing, can you merge the changes @michaelklishin

@shubhang93
Copy link
Contributor Author

also can we use a docker container, instead of installing rabbitmq-server on a debian OS?

@michaelklishin
Copy link
Owner

Containers make sense for Actions. I don't want to switch to container-based nodes only for local development but would consider a PR that adds support for containers as an option locally, similarly to how Bunny does it.

@shubhang93
Copy link
Contributor Author

This current PR adds support to use containers locally

@michaelklishin michaelklishin merged commit d3acd47 into michaelklishin:master Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants