Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShovelDefinition.SourceDeleteAfter should be type 'DeleteAfter' #197

Merged
merged 2 commits into from
Jun 3, 2021
Merged

ShovelDefinition.SourceDeleteAfter should be type 'DeleteAfter' #197

merged 2 commits into from
Jun 3, 2021

Conversation

ChunyiLyu
Copy link
Collaborator

@ChunyiLyu ChunyiLyu commented Jun 3, 2021 •
edited
Loading

Changes

  • ShovelDefinition.SourceDeleteAfter should be the same custom type as ShovelDefinition.DeleteAfter for better (un)marshaling
  • Update types for FederationDefinition and ShovelDefinition URI in README

@michaelklishin michaelklishin merged commit cbb439f into master Jun 3, 2021
@michaelklishin michaelklishin deleted the SourceDeleteAfter branch June 3, 2021 13:42
@ChunyiLyu ChunyiLyu mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChunyiLyu @michaelklishin