Fix go mod failures #128
Merged
Fix go mod failures #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because GOPATH was set to the current directory, all go commands would
fail because:
$GOPATH/go.mod exists but should not
There is no need to explicitly go get anymore, go modules now take care
of resolving missing deps just-in-time.
Ran `go mod tidy` to "add missing and remove unused modules", then `go
mod verify` to ensure that all deps have the expected content.
[#165674069]
Running `make docker`, then `make test` inside the container resolves all deps correctly. Tests fail because there is no RabbitMQ node, as expected. `make ginkgo` & `make cover` are also working correctly from the runtime perspective, but fail due to missing RabbitMQ. [#165674069]
|
I've just realised that I can only address server-release:v3.8.x is now passing with these changes: |
|
server-release:3.7.x is passing as well: |
|
Had to revert the pipelines, merging this will fix the current failures linked in the PR description. To fix the release failures, you will need to cut another release. server-release:v3.8.x is currently pulling |
michaelklishin
approved these changes
Apr 29, 2019
|
Thank you! |
|
Now that master is passing, are you going to tag a new release so that releases tests can pass as well? |
|
I just noticed that this broke the Travis build. Will have a go at fixing it. That must be the only thing that is blocking a new release, surely 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected to fix:
Will ensure all pipelines pass with the fork before submitting this as a regular PR (currently a draft).