Should password hashing helper functions use base64 encoding?

[mammothbane]

I tried using the password hashing functions provided by this package, but RabbitMQ was rejecting them (Rabbit v3.8.x). I reimplemented these functions myself, and I discovered that RabbitMQ doesn't understand base64 url encoding.

I'd make a PR, but there seem to be tests that should cover this, so I'm not sure if this is an incompatibility between RabbitMQ versions, and I don't have the time in the short term to sort that out.

[michaelklishin]

I cannot comment on what may be going on since you haven't provided any examples.

RabbitMQ HTTP API endpoint that creates or updates user records hasn't changed since 3.6.7 or so, rabbitmq/rabbitmq-management@44c1a5e#diff-c4fc8e74da6d82775c07e60925c441db is the most recent meaningful change.

There are rabbitmqadmin tests for the endpoint that do use base64.

The function that endpoint relies on, this one, does not perform any Base64-encoding.

[michaelklishin]

I cannot reproduce. Most likely your code performed double base64 encoding or something of that kind. Closing but if/when actual evidence is posted we can take another look.

[michaelklishin]

For a reason that escapes me, the new tests fail on Go 1.13 and tip but not on 1.14.

[michaelklishin]

This was due to my attempt at addressing #160.