Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let rollup typescript plugin properly generate type declaration files #40

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

michaeldzjap
Copy link
Owner

Closes #39

The official rollup TypeScript plugin does not automatically generate type declaration files. Using this workaround they are generated again.

@michaeldzjap michaeldzjap self-assigned this Jan 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #40 (a88099b) into develop (85428c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #40   +/-   ##
========================================
  Coverage    98.90%   98.90%           
========================================
  Files            2        2           
  Lines           91       91           
  Branches        13       13           
========================================
  Hits            90       90           
  Partials         1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85428c6...a88099b. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@michaeldzjap michaeldzjap merged commit 7e77bbb into develop Jan 8, 2022
@michaeldzjap michaeldzjap deleted the fix/#39-type-declarations branch January 8, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component no longer works with typescript since v3.1.0
2 participants