This repository has been archived by the owner on Dec 9, 2020. It is now read-only.
Content-Type validation is too strict #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naasir
commented
Nov 20, 2012
- Previous implementation required the form-encoded content-type to look exactly like: 'application/x-www-form-urlencoded'. However, certain popular libraries, such as jQuery default to adding the character encoding as a suffix: 'application/x-www-form-urlencoded; charset=utf8'. Furthermore, when an ajax request is made from certain browsers (Firefox, IE), the character encoding is automatically added as a suffix. This change makes the content-type check more forgiving for scenarios where additional character encoding information is supplied.
* Previous implementation required the form-encoded content-type to look exactly like: 'application/x-www-form-urlencoded'. However, certain popular libraries, such as jQuery default to adding the character encoding as a suffix: 'application/x-www-form-urlencoded; charset=utf8'. Furthermore, when an ajax request is made from certain browsers (Firefox, IE), the character encoding is automatically added as a suffix. This change makes the content-type check more forgiving for scenarios where additional character encoding information is supplied.
| @@ -123,34 +123,6 @@ public void WhenPasswordIsInvalid_ThenThrowsException() | |||
| } | |||
|
|
|||
| [Test] | |||
| public void WhenContentTypeIsInvalid_ThenThrowsException() | |||
There was a problem hiding this comment.
I removed this test case, as I moved the content-type check out of the PasswordTokenRequestAuthorizer into the PasswordRequestValidator, as the other validators were already checking the content-type there.
|
Very nice! This looks great. Thanks for taking care of it. |
micahlmartin
pushed a commit
that referenced
this pull request
Nov 20, 2012
Content-Type validation is too strict
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.