Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3010 date input extend events to include string value of date input #3318

Conversation

cd3859
Copy link
Contributor

@cd3859 cd3859 commented Mar 12, 2025

Summary of the changes

Modified IcChange emitter to hold a date objects field alongside date that keeps track of day, month and year inputs seperately.

Related issue

#3010

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@cd3859 cd3859 changed the base branch from v3.0.0/develop to develop March 12, 2025 16:57
@cd3859 cd3859 force-pushed the 3010-date-input-extend-events-to-include-string-value-of-date-input branch from 1a4563a to c25b39d Compare March 12, 2025 17:25
@cd3859 cd3859 marked this pull request as ready for review March 12, 2025 17:26
@cd3859 cd3859 force-pushed the 3010-date-input-extend-events-to-include-string-value-of-date-input branch from c25b39d to 7bdb523 Compare March 13, 2025 16:46
@cd3859 cd3859 marked this pull request as draft March 18, 2025 15:04
@cd3859 cd3859 force-pushed the 3010-date-input-extend-events-to-include-string-value-of-date-input branch from 7bdb523 to fe682d0 Compare March 18, 2025 17:17
GCHQ-Developer-741 and others added 2 commits March 19, 2025 09:19
…gn-changes-with-current-dev-version

2779 compare updated tree view design changes with current dev version
…ateObject

updated cypress test to better test newly added dateObject
@cd3859 cd3859 force-pushed the 3010-date-input-extend-events-to-include-string-value-of-date-input branch from 92d0ccb to 929f111 Compare March 19, 2025 09:20
@cd3859 cd3859 marked this pull request as ready for review March 19, 2025 09:20
@GCHQ-Developer-741
Copy link
Contributor

Not a major issue but when I enter the values into the input, I get multiple events emitted for when all three are present in the dateObject, one has a value of null and one has the correct value. Feel like it should just emit one event for this scenario?
image

@GCHQ-Developer-741
Copy link
Contributor

Also may need a rebase as its got some commits from a seperate issue

@cd3859 cd3859 force-pushed the 3010-date-input-extend-events-to-include-string-value-of-date-input branch 2 times, most recently from 1d572bb to 929f111 Compare March 20, 2025 13:24
@cd3859 cd3859 closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants