Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty state has black text for theme example in light mode #1324

Open
BluePandaCard opened this issue Jan 21, 2025 · 1 comment
Open

Empty state has black text for theme example in light mode #1324

BluePandaCard opened this issue Jan 21, 2025 · 1 comment
Assignees
Labels
type: bug 🐛 An unexpected problem or unintended behaviour
Milestone

Comments

@BluePandaCard
Copy link

Summary of the bug

When working on #1274 I noticed that empty state works fine in dark mode for the theme example, but in light mode it looks like this:

Image

It has theme="dark" so it should appear with white text.

I checked the ui kit repo and it works fine there so not sure what the issue might be here.

🧐 Expected behaviour

Should be able to see the text in both light and dark mode.

@ad9242
Copy link
Contributor

ad9242 commented Jan 29, 2025

it looks like the theme prop has not been added to the EmptyState component in the ui-kit.

work from mi6/ic-ui-kit#2513 seems to have been lost

@MI6-255 MI6-255 moved this from In Refinement to Ready for dev in Intelligence Community Design System Jan 30, 2025
@ad9242 ad9242 self-assigned this Jan 30, 2025
@ad9242 ad9242 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 An unexpected problem or unintended behaviour
Projects
Status: Dev In Progress
Development

No branches or pull requests

3 participants