Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some "Theme" / "Monochrome" components in code examples aren't very visible #1274

Open
GCHQ-Developer-847 opened this issue Dec 17, 2024 · 2 comments
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before type: bug 🐛 An unexpected problem or unintended behaviour
Milestone

Comments

@GCHQ-Developer-847
Copy link
Contributor

GCHQ-Developer-847 commented Dec 17, 2024

Summary of the bug

We've given components withtheme="dark" in "Theme" / "Monochrome" code examples a dark background to make them visible in light mode. However, the theme="light" examples don't have a light background when dark mode is turned on on the website, so they are quite difficult to see / there is not enough contrast.

🪜 How to reproduce

  1. Go to the "Theme" or "Monochrome" examples on the Code page for a component e.g. link, divider.
  2. See that the examples with theme="dark" are quite difficult to see

📸 Screenshots or code

🧐 Expected behaviour

I think it would be best if the components with theme="light" have a light background when in dark mode, just like those with theme="dark" have a dark background when in light mode.

Additional info

There are probably a few component pages for which this is an issue so it might involve looking through all of them to check. However, it's only an issue when we are showing two variants in one example i.e. when the dark background in light mode is only behind one of them, e.g.:
image

@GCHQ-Developer-847 GCHQ-Developer-847 added the type: bug 🐛 An unexpected problem or unintended behaviour label Dec 17, 2024
@GCHQ-Developer-299 GCHQ-Developer-299 added the good first issue A good starter issue if you haven't contributed to the ICDS before label Jan 15, 2025
@GCHQ-Developer-299 GCHQ-Developer-299 added this to the PI 10 V3 milestone Jan 15, 2025
@GCHQ-Developer-847
Copy link
Contributor Author

Noticed that the stepper Theme example doesn't have a dark background - would be good if this could be sorted as part of this ticket

@MI6-255 MI6-255 moved this from In Refinement to Ready for dev in Intelligence Community Design System Jan 16, 2025
@GCHQ-Developer-847
Copy link
Contributor Author

GCHQ-Developer-847 commented Jan 16, 2025

Sort out the section container examples as part of this (#1275).

This ticket should be to just do a general check over all code examples in dark mode to make sure that they look ok. Fix any small issues, raise a ticket for anything big / ic-ui-kit changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good starter issue if you haven't contributed to the ICDS before type: bug 🐛 An unexpected problem or unintended behaviour
Projects
Status: In Review
Development

No branches or pull requests

2 participants