Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bundler and friends #674

Merged
merged 6 commits into from
Dec 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler: 2.2.24
bundler: 2.3.4
bundler-cache: true
- run: bin/bundle --jobs=$(nproc) --retry=$(nproc)
- run: bin/rubocop -P
Expand All @@ -29,7 +29,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler: 2.2.24
bundler: 2.3.4
bundler-cache: true
- run: bin/bundle --jobs=$(nproc) --retry=$(nproc)
- run: bin/reek .
6 changes: 3 additions & 3 deletions .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler: 2.2.24
bundler: 2.3.4
bundler-cache: true

- name: Install Code Climate reporter
Expand Down Expand Up @@ -49,14 +49,14 @@ jobs:
strategy:
fail-fast: true
matrix:
ruby: [2.5, 2.6, 2.7, 3.0]
ruby: [2.5, 2.6, 2.7, 3.0, 3.1]

steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler: 2.2.24
bundler: 2.3.4
bundler-cache: true
- run: bin/appraisal install --jobs=$(nproc) --retry=$(nproc)
- run: bin/appraisal rspec --require spec_helper --tag ~perf
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ gemspec
LOCAL_GEMS = "Gemfile.local"

gem "appraisal"
gem "bundler"
gem "gem-release"
gem "github-markup"
gem "rack-test"
Expand Down
1 change: 0 additions & 1 deletion gemfiles/sidekiq_5.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
source "https://rubygems.org"

gem "appraisal"
gem "bundler"
gem "gem-release"
gem "github-markup"
gem "rack-test"
Expand Down
1 change: 0 additions & 1 deletion gemfiles/sidekiq_5.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
source "https://rubygems.org"

gem "appraisal"
gem "bundler"
gem "gem-release"
gem "github-markup"
gem "rack-test"
Expand Down
1 change: 0 additions & 1 deletion gemfiles/sidekiq_5.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
source "https://rubygems.org"

gem "appraisal"
gem "bundler"
gem "gem-release"
gem "github-markup"
gem "rack-test"
Expand Down
1 change: 0 additions & 1 deletion gemfiles/sidekiq_6.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
source "https://rubygems.org"

gem "appraisal"
gem "bundler"
gem "gem-release"
gem "github-markup"
gem "rack-test"
Expand Down
1 change: 0 additions & 1 deletion gemfiles/sidekiq_6.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
source "https://rubygems.org"

gem "appraisal"
gem "bundler"
gem "gem-release"
gem "github-markup"
gem "rack-test"
Expand Down
1 change: 0 additions & 1 deletion gemfiles/sidekiq_6.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
source "https://rubygems.org"

gem "appraisal"
gem "bundler"
gem "gem-release"
gem "github-markup"
gem "rack-test"
Expand Down
1 change: 0 additions & 1 deletion gemfiles/sidekiq_develop.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
source "https://rubygems.org"

gem "appraisal"
gem "bundler"
gem "gem-release"
gem "github-markup"
gem "rack-test"
Expand Down
2 changes: 1 addition & 1 deletion spec/sidekiq_unique_jobs/middleware/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
expect(queue_count("customqueue")).to eq(1)
end

it "does not queue duplicates when when calling delay" do
it "does not queue duplicates when when calling delay", sidekiq_ver: "< 7.0" do
Array.new(10) { PlainClass.delay(lock: :until_executed, queue: "customqueue").run(1) }

expect(queue_count("customqueue")).to eq(1)
Expand Down
2 changes: 1 addition & 1 deletion spec/sidekiq_unique_jobs/sidekiq_worker_methods_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def initialize(worker_class)
it { is_expected.to eq(UntilExecutedJob) }
end

context "when NameError is caught" do
context "when NameError is caught", ruby_ver: "< 3.0" do
let(:worker_class) { "UnknownConstant" }
let(:error_message) { "this class does not exist" }

Expand Down
6 changes: 4 additions & 2 deletions spec/support/sidekiq_meta.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ def sidekiq_redis_driver
Sidekiq.redis = redis
flush_redis

enable_delay = defined?(Sidekiq::Extensions) && Sidekiq::Extensions.respond_to?(:enable_delay!)
Sidekiq::Extensions.enable_delay! if enable_delay
if SidekiqUniqueJobs::VersionCheck.satisfied?(Sidekiq::VERSION, "< 7.0.0")
enable_delay = defined?(Sidekiq::Extensions) && Sidekiq::Extensions.respond_to?(:enable_delay!)
Sidekiq::Extensions.enable_delay! if enable_delay
end

if (sidekiq = example.metadata.fetch(:sidekiq, :disable))
sidekiq = :fake if sidekiq == true
Expand Down