Skip to content

Commit

Permalink
fix: longer waits to reduce flaky (GoogleCloudPlatform#8288)
Browse files Browse the repository at this point in the history
  • Loading branch information
engelke authored Aug 25, 2022
1 parent 15ab3cb commit 687a1e1
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ def increment_counter(request):
deferred.defer(do_something_later, my_key, 10)

# Use default URL and queue name, no task name, execute after 10s.
deferred.defer(do_something_later, my_key, 10, _countdown=10)
deferred.defer(do_something_later, my_key, 10, _countdown=20)

# Providing non-default task queue arguments
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)

return HttpResponse("Deferred counter increment.")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,19 +82,19 @@ def test_upload_and_view(version):
assert response.status_code == 200

# counter should be 10 almost immediately
time.sleep(5)
time.sleep(10)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "10"

# After 10 seconds, counter should be 20
time.sleep(10)
# After 20 seconds, counter should be 20
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "20"

# After 20 seconds, counter should be 30
time.sleep(10)
# After 40 seconds, counter should be 30
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "30"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ def increment_counter():
deferred.defer(do_something_later, my_key, 10)

# Use default URL and queue name, no task name, execute after 10s.
deferred.defer(do_something_later, my_key, 10, _countdown=10)
deferred.defer(do_something_later, my_key, 10, _countdown=20)

# Providing non-default task queue arguments
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)

return "Deferred counter increment."

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,20 +81,20 @@ def test_upload_and_view(version):
response = requests.get(f"https://{version_hostname}/counter/increment")
assert response.status_code == 200

# counter should be 10 almost immediately
time.sleep(5)
# counter should be 10 almost immediately. ALMOST immediately
time.sleep(10)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "10"

# After 10 seconds, counter should be 20
time.sleep(10)
# After 20 seconds, counter should be 20
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "20"

# After 20 seconds, counter should be 30
time.sleep(10)
# After 40 seconds, counter should be 30
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "30"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ def IncrementCounter(environ, start_response):
deferred.defer(do_something_later, my_key, 10)

# Use default URL and queue name, no task name, execute after 10s.
deferred.defer(do_something_later, my_key, 10, _countdown=10)
deferred.defer(do_something_later, my_key, 10, _countdown=20)

# Providing non-default task queue arguments
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)

start_response("200 OK", [("Content-Type", "text/html")])
return ["Deferred counter increment.".encode("utf-8")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,20 +81,20 @@ def test_upload_and_view(version):
response = requests.get(f"https://{version_hostname}/counter/increment")
assert response.status_code == 200

# counter should be 10 almost immediately
time.sleep(5)
# counter should be 10 almost immediately. ALMOST immediately
time.sleep(10)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "10"

# After 10 seconds, counter should be 20
time.sleep(10)
# After 20 seconds, counter should be 20
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "20"

# After 20 seconds, counter should be 30
time.sleep(10)
# After 40 seconds, counter should be 30
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "30"
Expand Down

0 comments on commit 687a1e1

Please sign in to comment.