Stop calling setup.py, use a build frontend
#2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.pysetup.py, use a build frontend
…calling-setup.py
+ temp comment out
Avasam
commented
Oct 18, 2024
Comment on lines
+365
to
+366
| "Can't find checker.py - please install PyChecker " | ||
| "(https://pypi.org/project/PyChecker/)\n" |
There was a problem hiding this comment.
This code is getting removed by #2412 anyway
(merging that first would reduce changes here by 1 file, but they can be done in any order)
|
Looks like all the artifacts are there I wonder if the repeated |
|
I'm feeling confident about this. I'll investigate whether all the flags are really necessary separately. This is a milestone in removing legacy/deprecated code from pywin32. It also opens the door for editable installs, different build frontends, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2208
Closes #1320 & closes #1487 by virtue of no longer supporting the install method the users were having issues with.
This is dependant on #2390DonePlease test carefully. Builds and wheels should be the same.