Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully fallback to disabling the cmdui in pywin.framework.dbgcommands.OnUpdateDebuggerBar #2320

Merged
merged 6 commits into from
Jan 4, 2025

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jul 25, 2024

If the bar name can't be obtained from ID, graciously fallback to closing instead of raising a TypeError.

Alternatively we can fallback to doing nothing.

CHANGES.txt Outdated Show resolved Hide resolved
@Avasam Avasam changed the title Graciously fallback to disabling the cmdui in pywin.framework.dbgcommands.OnUpdateDebuggerBar Gracefully fallback to disabling the cmdui in pywin.framework.dbgcommands.OnUpdateDebuggerBar Oct 4, 2024
@Avasam Avasam changed the title Gracefully fallback to disabling the cmdui in pywin.framework.dbgcommands.OnUpdateDebuggerBar Gracefully fallback to disabling the cmdui in pywin.framework.dbgcommands.OnUpdateDebuggerBar Oct 4, 2024
@Avasam Avasam force-pushed the OnUpdateDebuggerBar-TypeError branch from a840a68 to 2924e58 Compare October 4, 2024 22:54
@Avasam Avasam requested a review from mhammond October 18, 2024 18:40
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, fair enough, but please drop the changelog :)

@Avasam Avasam merged commit e2645cf into mhammond:main Jan 4, 2025
29 checks passed
@Avasam Avasam deleted the OnUpdateDebuggerBar-TypeError branch January 4, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants