Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Mapi call PyIMsgStore.StoreLogoff #2196

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

avivbrg
Copy link
Contributor

@avivbrg avivbrg commented Mar 7, 2024

The PyIMsgStore object is currently missing StoreLogoff - without properly shutting down the message store, session logoff and mapi.MAPIUninitialize() might hang indefinitely.

The PR adds the missing call and its related constants.

Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks, but there are a couple of tweaks I think should probably be made.

avivbrg added 2 commits March 13, 2024 17:21
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mhammond mhammond merged commit 2ef6883 into mhammond:main Mar 13, 2024
16 checks passed
@avivbrg avivbrg deleted the mapi_storelogoff branch March 14, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants