Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated definitions #2050

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Apr 21, 2023

Split off from #1990 to make it easier to review in isolation.

Remove dead code due to redefinitions obscuring the initial definitions before they're even used. Found through Ruff/Flake8's F811

@Avasam Avasam force-pushed the duplicate-and-obscured-declarations-and-redifinitions branch from a29b835 to 96db5b1 Compare April 21, 2023 04:52
@mhammond mhammond merged commit f6300f8 into mhammond:main Apr 22, 2023
@mhammond
Copy link
Owner

Thanks!

@Avasam Avasam deleted the duplicate-and-obscured-declarations-and-redifinitions branch April 22, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants