Add option to hide pagination for single page result #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. I'll fix them. |
mgwidmann
reviewed
May 1, 2019
mgwidmann
reviewed
May 1, 2019
|
I'd like to merge after the documentation is additionally updated. |
|
I'll try to resolve this within a day or two. |
|
@mgwidmann I think I fixed them based on the feedback. |
mgwidmann
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to hide pagination when total pages are one/zero. There is also related issue here, #75.
This PR adds a global option with key
hide_singleor you can set it as an option inpagination_linksfunction i.e.pagination_links(conn, page, hide_single: true). (also open to change the option to a different name, can't think of a better name at the moment).All tests are passing. Let me know if this is something you like or don't like. I'm okay with either decision. I can definitely hide the pagination in the template, but it's probably convenient to have it as an option.