empty config_filename as model_filename json

mgonzs13 · Jan 7, 2025 · a4c7c14 · a4c7c14
1 parent ebd7051
commit a4c7c14
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -62,7 +62,7 @@ ros2 action send_goal /say audio_common_msgs/action/TTS "{'text': 'Hello World f
 ### Spanish Example
 
 ```shell
-ros2 launch piper_bringup piper.launch.py model_filename:="es/es_ES/carlfm/x_low/es_ES-carlfm-x_low.onnx" config_filename:="es/es_ES/carlfm/x_low/es_ES-carlfm-x_low.onnx.json"
+ros2 launch piper_bringup piper.launch.py model_filename:="es/es_ES/carlfm/x_low/es_ES-carlfm-x_low.onnx"
 ```
 
 ```shell

diff --git a/piper_bringup/launch/piper.launch.py b/piper_bringup/launch/piper.launch.py
@@ -44,6 +44,8 @@ def run_piper(context: LaunchContext, repo, model, config, model_path, config_pa
             )
 
         if not config_path:
+            if not config:
+                config = f"{model}.json"
             config_path = hf_hub_download(
                 repo_id=repo, filename=config, force_download=False
             )
@@ -93,7 +95,7 @@ def run_piper(context: LaunchContext, repo, model, config, model_path, config_pa
     config_filename = LaunchConfiguration("config_filename")
     config_filename_cmd = DeclareLaunchArgument(
         "config_filename",
-        default_value="en/en_US/lessac/low/en_US-lessac-low.onnx.json",
+        default_value="",
         description="Hugging Face config filename for piper",
     )