Simplifications and various cleanups #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have a several bounds for the generic type parameters, so a where clause can help make the signature more readable. This is reflected both in the source and on docs.rs.
By adding
unstable_features = true
format_code_in_doc_comments = true
to a .rustfmt.toml file, we can get auto-formatted doctests. However,
several of our examples rely on visual alignment of lines before/after
wrapping, so here I've only applied the formatting that I liked.
This removes some complicated doctests with lots of setup. I believe the coercions tested by them are already covered by other unit tests, or by the type system itself. I left the two tests which ensure that the documented output of Options::new and Options::with_splitter match reality.
This is the default fill column in Emacs and I find the short lines more readable than ~100 column wide lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.