Replace WrapOptions with Into<Options> #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Koxiaet, this is cool! Thank you — i agree that this makes things much clearer :-) Can I get you to take out unrelated changes from your commits and also to squash the two commits into a single self-contained commit? I'll review the change now and try to point out what I mean. |
mgeisler
requested changes
Nov 13, 2020
|
I'm just trying to understand who the changes here affect the changes in #219 — I hope we can merge both soon and get a nice cleaned up API overall. |
mgeisler
approved these changes
Nov 14, 2020
|
Thanks for the updates and explanations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fairly confusing to have a struct and a nearly-identical trait. By centering everything around the concrete
Optionstype, the relationship betweenusizeandOptionscan be made more clear.