feature: add support of datastore struct tags in struct-tag rule #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Feb 17, 2025
| if w.isUserDefined(keyDatastore, opt) { | ||
| continue | ||
| } | ||
| return fmt.Sprintf("unknown option '%s' in Datastore tag", opt), false |
There was a problem hiding this comment.
Nitpicking
Suggested change
| return fmt.Sprintf("unknown option '%s' in Datastore tag", opt), false | |
| return fmt.Sprintf("unknown option '%s' in datastore tag", opt), false |
Or a variation of this, with quotes maybe.
I'm unsure google datastore tag should be considered as an acronym or a brand.
JSON, BSON, XML were acronym. But look at the way "protobuf" tag is reported.
There was a problem hiding this comment.
I have also hesitated with the name :)
The web site says "Datastore"
denisvmedia
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends struct-tag rule to check datastore tags as defined at https://pkg.go.dev/cloud.google.com/go/datastore (cf https://go.dev/wiki/Well-known-struct-tags#list-of-well-known-struct-tags)