-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): parse inline templates #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move Angular related class to `'./angular'`. 2. Add newlines/spaces to adjust to common style.
mgechev
force-pushed
the
templates
branch
2 times, most recently
from
September 18, 2016 01:44
9e884f6
to
b5c91fb
Compare
preslavsh
approved these changes
Sep 20, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the testing, I found problems with parsing
templates when pipes are not declared in same scope.
The other issue that I found was problem parsing "object.property" expressions .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains slightly more stuff that it is supposed to so I'll be more explicit with the explanation of the changes:
TemplateParser
and perform linting over them. There are a couple of limitations:sourceSpan
in the nodes produced by theTemplateParser
we cannot get very accurate information about where the actual linting error is. This issue is tracked by fix(template): mark the entire expression as invalid when the linter finds an error #88.src/**/*.ts
andtest/**/*.ts
. Since the project gained some popularity recently (7-8k downloads per day on npm), it'll be good to enforce some common coding style. In other words, I took thetslint.json
fromangular2-seed
and placed it here. This task will be also run in CI (currently the CI fails because the task will be introduced by this branch).tslint.json
.