-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bat's syntect syntax set #21
Conversation
2fb349e
to
5118dbb
Compare
@dpc could you check if this breaks the nix flake? I've never used nix and I don't know how to verify that this doesn't break it. This is adding a new directory and a file is being pulled from it during compilation time. If you could add a github action to check for that on PRs or at least let me know how I can verify this doesn't break, that'd be great. Otherwise the flake will likely eventually break. |
Unless you add some new directories, it shouldn't require any maintenance. If you want I could add a workflow file to build in it in the CI. |
Right that's what I did here, hence the question. So any new root directory should be added to that file and that's it? But yeah a workflow (assuming this doesn't take too long?) would be nice. No rush tho, I don't expect more directories popping up soon. |
As far as I can tell these new directories are not being used to build Rust. Do these files need to be present somewhere at runtime? |
@@ -26,6 +26,7 @@ | |||
".cargo" | |||
"src" | |||
"themes" | |||
"syntaxes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: Oh, you've already added it? Then it's done. :D
At build time. The file is being |
This pulls in bat's syntect syntax set. This is a draft and needs this a bit nicely with a script to download it, and also pull in all other languages that are here but aren't there in syntect's default syntax set.
Fixes #20