Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bat's syntect syntax set #21

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Use bat's syntect syntax set #21

merged 3 commits into from
Oct 24, 2023

Conversation

mfontanini
Copy link
Owner

This pulls in bat's syntect syntax set. This is a draft and needs this a bit nicely with a script to download it, and also pull in all other languages that are here but aren't there in syntect's default syntax set.

Fixes #20

@mfontanini mfontanini marked this pull request as ready for review October 24, 2023 01:16
@mfontanini
Copy link
Owner Author

@dpc could you check if this breaks the nix flake? I've never used nix and I don't know how to verify that this doesn't break it. This is adding a new directory and a file is being pulled from it during compilation time. If you could add a github action to check for that on PRs or at least let me know how I can verify this doesn't break, that'd be great. Otherwise the flake will likely eventually break.

@mfontanini mfontanini merged commit 66e34a2 into master Oct 24, 2023
@dpc
Copy link
Contributor

dpc commented Oct 24, 2023

> nix build github:mfontanini/presenterm
18:39:31 ~ took 2m20s 

Unless you add some new directories, it shouldn't require any maintenance.

If you want I could add a workflow file to build in it in the CI.

@mfontanini mfontanini deleted the use-bat-syntaxes branch October 24, 2023 01:44
@mfontanini
Copy link
Owner Author

Unless you add some new directories, it shouldn't require any maintenance.

Right that's what I did here, hence the question. So any new root directory should be added to that file and that's it? But yeah a workflow (assuming this doesn't take too long?) would be nice. No rush tho, I don't expect more directories popping up soon.

@dpc
Copy link
Contributor

dpc commented Oct 24, 2023

As far as I can tell these new directories are not being used to build Rust. Do these files need to be present somewhere at runtime?

@@ -26,6 +26,7 @@
".cargo"
"src"
"themes"
"syntaxes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Oh, you've already added it? Then it's done. :D

@mfontanini
Copy link
Owner Author

At build time. The file is being include!d at build time. And yep, I added it because I felt like I probably should but I couldn't verify that it actually worked. Sweet, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How I could achieve Elixir syntax highlighting?
2 participants