Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle this better #80

Closed
github-actions bot opened this issue Oct 25, 2022 · 3 comments
Closed

handle this better #80

github-actions bot opened this issue Oct 25, 2022 · 3 comments

Comments

@github-actions
Copy link

// TODO handle this better
}
const installedHash = await getHash(oldModPath);
if (modData.hash !== installedHash || modData.releaseDate > installedMods[installedModIndex].releasedOn) {
logger.log(`${mod.name} has an update, downloading...`);


This issue was generated by todo-issue based on a TODO comment in 13657cb. It's been assigned to @meza because they committed the code.
@github-actions
Copy link
Author

handle this better

// TODO handle this better
}
const installedModIndex = getInstallation(mod, installedMods);
const oldModPath = path.resolve(configuration.modsFolder, installedMods[installedModIndex].fileName);


This comment was generated by todo-issue based on a TODO comment in 13657cb. It's been assigned to @meza because they committed the code.

@meza meza removed their assignment Jan 21, 2023
@meza meza added this to the 1.2.1 milestone Jan 27, 2023
@meza meza moved this to Done in Minecraft Mod Manager Jan 30, 2023
@meza meza mentioned this issue Jan 30, 2023
@meza meza closed this as completed Jan 31, 2023
@github-actions
Copy link
Author

github-actions bot commented Feb 3, 2023

🎉 This issue has been resolved in version 1.2.1-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Author

🎉 This issue has been resolved in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant