Update dataframe_utilities for threshold/realization data #1696
Conversation
…ponent. had to add the "diagnostic" column to our BOM data, there might be a step missing in our pre-processing. Will investigate
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 112 112
Lines 10334 10396 +62
=======================================
+ Hits 10146 10207 +61
- Misses 188 189 +1
Continue to review full report at Codecov.
|
| var_type = variable | ||
| else: | ||
| continue | ||
|
|
There was a problem hiding this comment.
do we need to change the tests?
There was a problem hiding this comment.
You mean because of the code coverage issue? I was also confused about this, because the tests do include a case where the continue statement would be executed. Apparently this is a known issue, due to the way the python optimizer works nedbat/coveragepy#198
| return cubelist.merge_cube() | ||
|
|
||
| cube = cubelist.merge_cube() | ||
| cube.attributes["cube_type"] = "observations" |
There was a problem hiding this comment.
probably need to differentiate between obs and analyses? Where was this set previously ? Was it set? How do UKMO set this?
|
Closing for now, until format of input data is decided. |
Update dataframe_utilities to work with dataframes having a threshold or realization column instead of percentile.
@anja-bom
Description
Testing: