Allow resolving index.* modules with non-.js file extensions. #10027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit enabled importing index.* modules at runtime, but unfortunately the build-time Resolver logic also needed updating, which will require a new Meteor release.
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @justinanastos via Slack, files with non-
.jsfile extensions (e.g.index.tsx) cannot be used to make a directory importable in the same way that anindex.jsmodule can.Fixing this involves updating both the runtime module system and our build-time
Resolverlogic (this PR).Unfortunately this fix will have to wait for the next Meteor release, since it involves changes to the build tool.