This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Switch versions explicitly #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndingVersion` instead of trying to switch every time a browser reload is detected
|
Any idea about those test failures? |
|
@benjamn AFAICT the changes in this PR are unrelated to these errors; they all mention 403 responses. |
|
@wojtkowiak do these changes mean that Meteor will no longer automatically switch to a new version, whenever it becomes available, but we have to call this newly added function to switch versions? I think that would be nice, but it should definitely be configurable (I guess that would need to happen in the package responsible for hot-reload rather than this cordova plugin though). |
|
@KoenLav take a look at meteor/meteor#10219 |
benjamn
approved these changes
Nov 15, 2018
|
Maybe related to test failures? Not clear to me why the testing if statement is taken out |
zhang2118
pushed a commit
to zhang2118/cordova-plugin-meteor-webapp
that referenced
this pull request
Jan 13, 2019
mslobodan
added a commit
to mslobodan/reloader
that referenced
this pull request
Aug 29, 2019
…r-webapp#62. This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan
added a commit
to mslobodan/reloader
that referenced
this pull request
Aug 29, 2019
…r-webapp#62. This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan
added a commit
to mslobodan/reloader
that referenced
this pull request
Aug 29, 2019
…r-webapp#62. This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan
added a commit
to mslobodan/reloader
that referenced
this pull request
Aug 29, 2019
…r-webapp#62. This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan
added a commit
to mslobodan/reloader
that referenced
this pull request
Aug 29, 2019
…r-webapp#62. This version of package requires you to call Reloader.configure in order to activate this package.
mslobodan
added a commit
to mslobodan/reloader
that referenced
this pull request
Aug 29, 2019
…r-webapp#62. This version of package requires you to call Reloader.configure in order to activate this package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes switching versions to be done explicitly with call to
WebAppLocalServer.switchToPendingVersioninstead of trying to switch every time a browser reload is detected.This is another part of extracted fixes from @matdurand's commits.
This and the other PRs were running on production in my company's fork more than 1 year now.
Refs:
#48
meteor/meteor#8063 (comment)
Fixes: #29