Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize htmljs, html-tools, blaze-tools, spacebars-compiler, etc #321

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

nathan-muir
Copy link
Contributor

Hi,

Some old changes that I didn't create a PR for, as there was no maintainer.

Just went through and converted a few packages to imports/exports, but kept the existing inter-package api's the same.

@filipenevola
Copy link
Collaborator

Hi @nathan-muir thank you.

As you can see here there are 10 tests failing:

passed/expected/failed/total 285 / 0 / 10 / 295

On master they are all passing, it's probably something that you changed in your branch.

Could you take a look?

@filipenevola filipenevola added the pending-tests Tests are not passing, stuck or we need new tests label Mar 18, 2021
@nathan-muir
Copy link
Contributor Author

@filipenevola Tests should be passing now, but ci/circleci is stuck?

@filipenevola
Copy link
Collaborator

@nathan-muir the tests are passing, the job stuck on CircleCI are the old ones as this branch was old I believe.

@filipenevola
Copy link
Collaborator

I think we could create a branch with your changes + hot-module-replacement and have a new beta.

What do you think @nathan-muir @zodern ?

Maybe we are even going to get a conflict between these two branches.

@filipenevola filipenevola removed the pending-tests Tests are not passing, stuck or we need new tests label Mar 19, 2021
@filipenevola filipenevola changed the base branch from master to release-2.4 March 19, 2021 20:33
@filipenevola
Copy link
Collaborator

@nathan-muir could you check the conflicts?

As you refactored the code I believe you are the best person to understand what is the version that should be maintained.

The conflicts are probably coming from the HMR changes.

@filipenevola filipenevola added the in-development We are already working on it label Mar 19, 2021
@nathan-muir
Copy link
Contributor Author

@filipenevola Should be solved now

@filipenevola
Copy link
Collaborator

Great.

@filipenevola filipenevola merged commit 5fa8383 into meteor:release-2.4 Mar 22, 2021
@nathan-muir nathan-muir mentioned this pull request Mar 23, 2021
@filipenevola filipenevola added this to the 2.4 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-development We are already working on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants