-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize htmljs, html-tools, blaze-tools, spacebars-compiler, etc #321
Conversation
Hi @nathan-muir thank you. As you can see here there are 10 tests failing:
On master they are all passing, it's probably something that you changed in your branch. Could you take a look? |
6389ee0
to
4755aa6
Compare
@filipenevola Tests should be passing now, but ci/circleci is stuck? |
@nathan-muir the tests are passing, the job stuck on CircleCI are the old ones as this branch was old I believe. |
I think we could create a branch with your changes + hot-module-replacement and have a new beta. What do you think @nathan-muir @zodern ? Maybe we are even going to get a conflict between these two branches. |
@nathan-muir could you check the conflicts? As you refactored the code I believe you are the best person to understand what is the version that should be maintained. The conflicts are probably coming from the HMR changes. |
4755aa6
to
68d463b
Compare
@filipenevola Should be solved now |
68d463b
to
ed9299e
Compare
Great. |
Hi,
Some old changes that I didn't create a PR for, as there was no maintainer.
Just went through and converted a few packages to imports/exports, but kept the existing inter-package api's the same.