CSS modules changes to allow plugins more control #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y were restricted to output that would be run through JSON.stringify)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS modules changes to allow plugins more control
This PR does 2 things:
tag-handler.jslines 383 - 388 andvue-compiler.js: grants CSS modules plugins (i.e. my plugin 😄) the ability to fully control the CSS modules output. Previously, this output was being run throughJSON.stringifyin the compiler, now it's being output directly. This is important for me because the lastest version of my CSS modules plugin has the ability to output aProxyobject that displays a helpful error message if the developer attempts to use a class that doesn't exist.tag-handler.jslines 446-452: updates the built-in CSS modules code so it still works (no functional changes).