Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor bug fixes #894

Merged
merged 7 commits into from
Oct 30, 2024
Merged

fix: minor bug fixes #894

merged 7 commits into from
Oct 30, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Oct 28, 2024

  • Bug with typegraph context reset around deno_modules
  • Bug with typegate onPush hook error detection and typegraph parsing of such errors
  • Bug with artifact resolution when they're reused.
  • Bug with return type of the KvRuntime get functions
  • Bumps metatype to 0.5.0-rc.3

Migration notes

N/A


  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am requested a review from Natoandro October 28, 2024 19:44
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

src/typegraph/deno/src/runtimes/kv.ts Show resolved Hide resolved
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (0a27b94) to head (5417385).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/runtimes/kv.ts 86.36% 3 Missing ⚠️
src/typegraph/deno/src/utils/func_utils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   76.77%   76.77%   -0.01%     
==========================================
  Files         149      149              
  Lines       18233    18244      +11     
  Branches     1768     1765       -3     
==========================================
+ Hits        13998    14006       +8     
- Misses       4212     4215       +3     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohe-Am Yohe-Am enabled auto-merge (squash) October 29, 2024 21:20
@Yohe-Am Yohe-Am requested a review from Natoandro October 29, 2024 21:21
@Yohe-Am Yohe-Am merged commit bb42c00 into main Oct 30, 2024
14 checks passed
@Yohe-Am Yohe-Am deleted the fix/papercut-series-1 branch October 30, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants