feat(subs): retry + timeout on save #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
==========================================
- Coverage 77.08% 76.92% -0.17%
==========================================
Files 148 149 +1
Lines 17509 17720 +211
Branches 1721 1729 +8
==========================================
+ Hits 13497 13631 +134
- Misses 3993 4066 +73
- Partials 19 23 +4 ☔ View full report in Codecov by Sentry. |
d1e8d8a to
6ce341a
Compare
Yohe-Am
approved these changes
Oct 3, 2024
3 tasks
michael-0acf4
added a commit
that referenced
this pull request
Oct 4, 2024
Follow up of #863 When multiple start occurs for redis, some schedules can happen **exactly** at the same time resulting into the same identifier (and leading to an inconsistent state). This solution simply combines the `schedule` with the run_id making it unique instead of using it as is. ```gql mutation AllAtOnce { a: start_retry(kwargs: { .. }) # => calls add_schedule( ... date ...) b: start_retry(kwargs: { .. }) c: start_retry(kwargs: { .. }) d: start_retry(kwargs: { .. }) e: start_retry(kwargs: { .. }) f: start_retry(kwargs: { .. }) # .. } ``` #### Migration notes None - [ ] The change comes with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port and improve retry/timeout.
Migration notes
N/A