Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grpc runtime #819

Merged
merged 39 commits into from
Sep 18, 2024
Merged

feat: grpc runtime #819

merged 39 commits into from
Sep 18, 2024

Conversation

j03-dev
Copy link
Contributor

@j03-dev j03-dev commented Aug 21, 2024

Migration notes

...

  • The change comes with new or modified tests
  • End-user documentation is updated to reflect the change
  • Hard-to-understand functions have explanatory comments

Copy link

linear bot commented Aug 21, 2024

MET-542 `GrpcRuntime`

@j03-dev j03-dev force-pushed the feat/met-542-grpc-runtime branch 2 times, most recently from fa49397 to c316cd0 Compare August 26, 2024 16:40
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💪

PS: If you find any way to lighten the addition of new runtimes, feel free to write an RFC ;-)

typegraph/core/src/runtimes/grpc/type_generation.rs Outdated Show resolved Hide resolved
typegraph/core/src/runtimes/grpc/type_generation.rs Outdated Show resolved Hide resolved
@Natoandro
Copy link
Contributor

Can you update the description?

Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests required!

@Natoandro Natoandro mentioned this pull request Aug 29, 2024
@j03-dev j03-dev force-pushed the feat/met-542-grpc-runtime branch from 9942338 to 30d1470 Compare August 29, 2024 20:06
@j03-dev j03-dev force-pushed the feat/met-542-grpc-runtime branch from 30d1470 to f79375e Compare August 30, 2024 17:48
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of get why you went the parser way but handling things like import resolution for example is not an easy task. Adapting protobuf_parser to fit our needs might solve this. wdyt?

common.proto

syntax = "proto3";

package example;

message User {
    string name = 1;
    int32 id = 2;
}

main.proto

syntax = "proto3";

package example;

import "common.proto"; // <= here

service UserService {
    rpc listAll(User) returns (User);
}

Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

src/typegraph/core/src/runtimes/grpc/type_generation.rs Outdated Show resolved Hide resolved
docs/metatype.dev/docs/reference/runtimes/grpc/index.mdx Outdated Show resolved Hide resolved
docs/metatype.dev/docs/reference/runtimes/grpc/index.mdx Outdated Show resolved Hide resolved
docs/metatype.dev/docs/reference/runtimes/grpc/index.mdx Outdated Show resolved Hide resolved
tests/runtimes/grpc/geography.py Outdated Show resolved Hide resolved
tests/runtimes/grpc/helloworld.py Outdated Show resolved Hide resolved
tests/runtimes/grpc/helloworld.ts Outdated Show resolved Hide resolved
tools/compose/proto/helloworld.proto Outdated Show resolved Hide resolved
michael-0acf4
michael-0acf4 previously approved these changes Sep 11, 2024
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged as a first iteration👍
lgtm

@j03-dev j03-dev removed the request for review from zifeo September 12, 2024 06:52
michael-0acf4
michael-0acf4 previously approved these changes Sep 13, 2024
@j03-dev j03-dev requested review from Natoandro and removed request for Natoandro September 14, 2024 03:10
@j03-dev j03-dev requested a review from Natoandro September 18, 2024 06:56
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Waiting for the tests to pass...

@j03-dev j03-dev merged commit c5d2ba3 into main Sep 18, 2024
10 of 11 checks passed
@j03-dev j03-dev deleted the feat/met-542-grpc-runtime branch September 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants