Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli)!: configurable backoff #789

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

Natoandro
Copy link
Contributor

@Natoandro Natoandro commented Jul 10, 2024

  • Make the backoff configurable through the --retry and --retry-interval-ms options.
  • The default max retry count is changed to 0 on the default mode, and remains 3 on the watch mode.
  • The --max-parallel-loads option has been renamed to --threads.

Migration notes

The --max-parallel-loads option has been renamed to --threads.

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Natoandro Natoandro changed the title feat(cli): configurable backoff feat(cli)!: configurable backoff Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.91%. Comparing base (a2a97ed) to head (981778e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   69.91%   69.91%           
=======================================
  Files         139      139           
  Lines       16181    16181           
  Branches     1475     1475           
=======================================
  Hits        11313    11313           
  Misses       4843     4843           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro merged commit aaa1b84 into main Jul 10, 2024
13 checks passed
@Natoandro Natoandro deleted the feat/configurable-backoff branch July 10, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants