-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: /docs/reference/metagen
+ /docs/guides/wasm-functions
#751
Conversation
@coderabbitai review |
WalkthroughThe changes encompass updates to Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant CLI
participant Metagen
participant Target
User->>CLI: Execute command with target
CLI->>Metagen: Check target in configuration
Metagen->>CLI: Return available keys (if target not found)
CLI->>User: Error message (if target not found)
alt Target Found
CLI->>Target: Execute target-specific logic
Target->>CLI: Return results
CLI->>User: Display results
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 17
Outside diff range and nitpick comments (5)
examples/typegraphs/metagen/ts/remix.ts (1)
9-9
: Clarify the comment regardingS3Runtime
or consider implementing it if it's part of the planned features.typegate/tests/runtimes/wasm_wire/rust/build.sh (1)
Line range hint
8-8
: The commandghjk x install-wasi-adapter
appears to be incorrect. Did you meangh install-wasi-adapter
?website/src/components/MiniQL/index.tsx (1)
Line range hint
69-69
: Add missing dependencies to useMemo to ensure the component updates correctly when props change.- const fetcher = useMemo( - () => - createGraphiQLFetcher({ - url: `${tgUrl}/${typegraph}`, - }), - [], - ); + const fetcher = useMemo( + () => + createGraphiQLFetcher({ + url: `${tgUrl}/${typegraph}`, + }), + [tgUrl, typegraph], # Added missing dependencies + );website/docs/reference/metagen/index.mdx (2)
10-12
: Ensure the beta warning is prominently displayed and consider adding more details about what aspects are unstable.
16-16
: Consider linking directly to the pages for the meta CLI and typegraph SDKs for user convenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An opinionated one: mdk
→ fdk
?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 72.99% 73.06% +0.06%
==========================================
Files 117 116 -1
Lines 14181 14150 -31
Branches 1414 1416 +2
==========================================
- Hits 10351 10338 -13
+ Misses 3803 3786 -17
+ Partials 27 26 -1 ☔ View full report in Codecov by Sentry. |
The base branch was changed.
90f6de8
to
2cc0dc2
Compare
/docs/reference/metagen
/docs/guides/wasm-functions
/docs/guides/external-functions
MDK-492.
Migration notes
...
Summary by CodeRabbit
New Features
metagen
with different generators and paths for TypeScript, Python, and Rust.TGExample
.Bug Fixes
.gitignore
to exclude*.wasm
files.Documentation
metagen
.Refactor
HashMap
toBTreeMap
andHashSet
toBTreeSet
in various modules for better data structure handling.Typegate
class.Chores