-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the exit message is not dropped #236
Ensure the exit message is not dropped #236
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -145,8 +145,10 @@ public void execute() throws CommandExecutionException { | |||
handleConversion(source, toFormat, writer, loader); | |||
} | |||
} | |||
} catch (IOException | IllegalArgumentException ex) { | |||
} catch (IllegalArgumentException ex) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't a step through exception catch on the generic Exception type for unexpected errors just to log them if no action taken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is about passing on their messages to the CLI handler with the appropriate error code.
283b8cd
to
a950ac1
Compare
…ol to exit silently with an error code.
a950ac1
to
f45a272
Compare
a3209a8
into
metaschema-framework:release/2.0
Committer Notes
This PR fixes a bug that causes the exit message to be dropped and the CLI tool to exit silently with an error code.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: