Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function normalize-space() is not implemented in Metapath processor #133

Closed
6 tasks
Tracked by #734
aj-stein-gsa opened this issue Sep 27, 2024 · 1 comment · Fixed by #163
Closed
6 tasks
Tracked by #734

Function normalize-space() is not implemented in Metapath processor #133

aj-stein-gsa opened this issue Sep 27, 2024 · 1 comment · Fixed by #163
Labels
enhancement New feature or request java Pull requests that update Java code
Milestone
v1.2.0

Comments

@aj-stein-gsa
Copy link
Contributor

aj-stein-gsa commented Sep 27, 2024 •
edited
Loading

User Story

As a developer of Metaschema-based software, in order to write more efficient and easier to read Metapath in my models, I would like this library to implement the function normalize-space().

Goals

  • Implement the function for Metapath use
  • Provide positive correct use of the function in unit tests
  • Provide incorrect correct negative use of the function unit tests

Dependencies

N/A

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

Revisions

No response
@aj-stein-gsa aj-stein-gsa added enhancement New feature or request java Pull requests that update Java code labels Sep 27, 2024
@aj-stein-gsa aj-stein-gsa mentioned this issue Sep 27, 2024
Closed
16 tasks
@david-waltermire david-waltermire added this to the v1.2.0 milestone Sep 27, 2024
@david-waltermire david-waltermire moved this from To Triage to Ready in Spec and Tooling Work Board Sep 28, 2024
@david-waltermire
Copy link
Contributor

This can be done as a follow on to #140 by providing a function that wraps the IStringItem.normalizeSpace() method.

david-waltermire added a commit to david-waltermire/metaschema-java that referenced this issue Oct 5, 2024
@david-waltermire
Added support for the normalize-space Metapath function. Had to fix a…
8d6343f 
… bug in the string literal handling that inconsistently caused leading and trailing quotes to be removed. Also fixed an issue with the build that was causing surefire to inconsistently handle a JUnit extension. Resolves metaschema-framework#133.
@david-waltermire david-waltermire mentioned this issue Oct 5, 2024
Merged
8 tasks
@david-waltermire david-waltermire linked a pull request Oct 5, 2024 that will close this issue
Support the normalize-space Metapath function #163
Merged
8 tasks
david-waltermire added a commit that referenced this issue Oct 5, 2024
@david-waltermire @aj-stein-gsa
Support the normalize-space Metapath function (#163)
b136be3 
* Added support for the normalize-space Metapath function. Had to fix a bug in the string literal handling that inconsistently caused leading and trailing quotes to be removed. Also fixed an issue with the build that was causing surefire to inconsistently handle a JUnit extension. Resolves #133.

* Apply suggestions from code review

Co-authored-by: A.J. Stein <aj@gsa.gov>

* Cleaned up function execution to reduce complexity and to ensure that a focus is checked for if required using focusDependent().

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request java Pull requests that update Java code
Projects
Spec and Tooling Work Board
Archived in project
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Support the normalize-space Metapath function david-waltermire/metaschema-java
2 participants
@david-waltermire @aj-stein-gsa